branch Hooks create view video and related videos #3
Conversation
|
✔️ Deploy Preview for naughty-franklin-3633f3 ready! 🔨 Explore the source changes: 9979c7f 🔍 Inspect the deploy log: https://app.netlify.com/sites/naughty-franklin-3633f3/deploys/61082068036a290008880ba3 😎 Browse the preview: https://deploy-preview-3--naughty-franklin-3633f3.netlify.app/ |
|
|
||
| describe('VideoGrid', () => { | ||
| it('Should render Text wizeline', () => { | ||
| const { getByText } = render( |
There was a problem hiding this comment.
instead of destructuring the return of the render method, it is better to use screen.getByText
| if (error !== null) { | ||
| console.log(error); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
It is almost always wrong to use this rule. Right here I think you added it to not add fetchRelation and fetchVideo, the definition of those functions should not be changing, and if they are and triggering the useEffect callback to run more times than needed then we need to to something with those functions instead of adding this disable.
Let me know if you have questions on this as this took me a long time to fully wrap my head around this
| } | ||
| }, [value, data, fetchSearch, error]); | ||
|
|
||
| const enterPressed = async (event) => { |
There was a problem hiding this comment.
you have two different enterPressed that I think could be only one function living inside the Header component, so instead of passing enterPressed you can pass value and move enterPressed to the Header component
in this challenge,