Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up TraitConstructor #585

Closed
neko-kai opened this issue Jul 17, 2019 · 0 comments
Closed

Speed up TraitConstructor #585

neko-kai opened this issue Jul 17, 2019 · 0 comments
Labels
distage (di) distage-testkit enhancement zio ZIO-specific features or interop
Projects
DIStage
Milestone
1.0

Comments

@neko-kai
Copy link
Member

neko-kai commented Jul 17, 2019 •
edited

TraitConstructorMacro is too slow, possibly due to calling ProviderMagnetMacro, or possibly due to generating too many Tags either way, investigate its usage and drop its compile time to an unnoticeable level.

This is required for usable ZIO Env-based tests: #586
@neko-kai neko-kai self-assigned this Jul 17, 2019
@neko-kai neko-kai added this to the 0.10 milestone Jul 17, 2019
@neko-kai neko-kai added this to To do in DIStage via automation Jul 17, 2019
@neko-kai neko-kai mentioned this issue Jul 18, 2019
Closed
@neko-kai neko-kai removed their assignment Jul 18, 2019
neko-kai added a commit that referenced this issue Nov 30, 2019
@neko-kai
Fix #585 *Constructor macros now construct final tree directly, witho…
ac66810 
…ut expansion of ProviderMacro

* simplfy model, remove DependencyContext
@neko-kai neko-kai modified the milestones: 0.10, 0.9 Nov 30, 2019
DIStage automation moved this from To do to Done Dec 4, 2019
@pshirshov pshirshov modified the milestones: 0.12, 0.11 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distage (di) distage-testkit enhancement zio ZIO-specific features or interop
Projects
DIStage
  
Done
Milestone
1.0
Development

No branches or pull requests
2 participants
@pshirshov @neko-kai