Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logstage: Fix withFiberId and withDynamic AbstractLoggerF-based constructors (#508, #1872) #1969

Merged
merged 1 commit into from Jun 27, 2023

Conversation

neko-kai
Copy link
Member

They weren't actually doing anything

@neko-kai neko-kai requested a review from pshirshov as a code owner June 23, 2023 22:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #1969 (622efc9) into develop (48754ee) will increase coverage by 0.03%.
The diff coverage is 7.40%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #1969      +/-   ##
===========================================
+ Coverage    64.46%   64.50%   +0.03%     
===========================================
  Files          546      546              
  Lines        10928    10933       +5     
===========================================
+ Hits          7045     7052       +7     
+ Misses        3883     3881       -2     

@neko-kai neko-kai merged commit 80cb7bc into develop Jun 27, 2023
29 checks passed
@neko-kai neko-kai deleted the feature/abstractloggerf-fix-noop branch June 27, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants