Binding implementation to multiple interfaces #652
Conversation
|
Things to do:
|
Codecov Report
@@ Coverage Diff @@
## develop #652 +/- ##
===========================================
- Coverage 75.03% 75.02% -0.02%
===========================================
Files 532 532
Lines 13116 13147 +31
Branches 642 660 +18
===========================================
+ Hits 9842 9863 +21
- Misses 3274 3284 +10
Continue to review full report at Codecov.
|
distage/distage-model/src/main/scala/izumi/distage/model/definition/dsl/ModuleDefDSL.scala
Outdated
Show resolved
Hide resolved
VladPodilnyk
force-pushed
the
feature/517-binding-to-multiple-interfaces
branch
from
71fa98b
to
6102b10
Compare
There was a problem hiding this comment.
@VladPodilnyk do you think yoo could add a test that uses .named/.tagged in this PR?
VladPodilnyk
force-pushed
the
feature/517-binding-to-multiple-interfaces
branch
from
6102b10
to
497a769
Compare
|
@neko-kai, how much time do I have? or you want to procced by yourself? |
|
@VladPodilnyk There's no rush, just checking! |
|
@neko-kai, ok, I was just asking, because I'm a little bit slow... but if there is time, I would like to proceed. |
This commit is actually ported version of the following PR: 478820a made by Yaroslav Sahach (ysahach@playq.net).
distage/distage-core/src/test/scala/izumi/distage/dsl/DSLTest.scala
Outdated
Show resolved
Hide resolved
.../distage-model/src/main/scala/izumi/distage/model/definition/dsl/AbstractBindingDefDSL.scala
Outdated
Show resolved
Hide resolved
distage/distage-model/src/main/scala/izumi/distage/model/definition/dsl/ModuleDefDSL.scala
Outdated
Show resolved
Hide resolved
VladPodilnyk
force-pushed
the
feature/517-binding-to-multiple-interfaces
branch
from
97e48ee
to
fc27f01
Compare
.../distage-model/src/main/scala/izumi/distage/model/definition/dsl/AbstractBindingDefDSL.scala
Outdated
Show resolved
Hide resolved
|
@neko-kai thanks a lot for your patience and support with this PR! |
|
@VladPodilnyk Nice! Congratulations 🚀 |
|
😊, @neko-kai could I approach another one? I can take anything from https://github.com/7mind/izumi/milestone/9 or maybe you have smth particular in mind? |
|
@VladPodilnyk Of these I'd say the best to do is LogStage: add support for strings with .stripMargin – it's medium-hard difficulty, but really useful if it works because we can start using multi-line strings in logs properly then. |
|
then I'll take it (#684), ok? |
* Binding implementation to multiple interfaces This commit is actually ported version of the following PR: 478820a made by Yaroslav Sahach. * fix relationship between types. * wip: playing around. * wip... * .to[] and .to[](name) - works. * rework implementation. * ready to review. * apply suggestions. * pattern match inside multiple bind interpreter.
|
@VladPodilnyk Sure! Thank you! |
This commit is actually ported version of the following PR:
478820a
made by Yaroslav Sahach (#528).