Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distage-roles: move *Impls to companion object #701

Merged
merged 2 commits into from Oct 21, 2019

Conversation

neko-kai
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #701 into develop will increase coverage by 0.02%.
The diff coverage is 87.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #701      +/-   ##
===========================================
+ Coverage    75.35%   75.37%   +0.02%     
===========================================
  Files          533      532       -1     
  Lines        13039    13044       +5     
  Branches       631      630       -1     
===========================================
+ Hits          9825     9832       +7     
+ Misses        3214     3212       -2
Impacted Files Coverage Δ
...e/roles/services/PlanCircularDependencyCheck.scala 60% <ø> (ø) ⬆️
...istage/roles/logger/SimpleLoggerConfigurator.scala 80% <ø> (ø) ⬆️
...main/scala/izumi/distage/roles/internal/Help.scala 0% <ø> (ø) ⬆️
...la/izumi/distage/roles/internal/ConfigWriter.scala 85.91% <ø> (ø) ⬆️
...r/plugins/macrodefs/StaticPluginCheckerMacro.scala 71.42% <100%> (ø) ⬆️
...services/st/adapter/DistagePluginTestSupport.scala 96.87% <100%> (ø) ⬆️
...la/izumi/distage/roles/services/PluginSource.scala 100% <100%> (ø)
...stkit/services/st/adapter/DistageTestSupport.scala 97.22% <100%> (ø) ⬆️
...t/services/dstest/DistageTestEnvironmentImpl.scala 100% <100%> (ø) ⬆️
...in/scala/izumi/distage/roles/RoleAppLauncher.scala 95.12% <100%> (+0.06%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194ac6c...fb7abfd. Read the comment docs.

…, reformat fundamentals-reflection, move CodePositionMaterializer macro to fundamentals-platform
@neko-kai neko-kai merged commit 6c38a36 into develop Oct 21, 2019
@neko-kai neko-kai deleted the feature/impls-in-object branch November 24, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants