-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Non-Default Namespace for Model Type Export #29
Support Non-Default Namespace for Model Type Export #29
Conversation
.split("/") | ||
.at(-1)!; // get only model name without directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to extract History
from Common/History
, otherwise model:show command becomes like model:show App\\Models\\Common\\Common/History
const routeListCommand = `php artisan route:list ${options.vendorRoutes ? "" : "--except-vendor" | ||
} --json > ${tmpDir}/route.json`; | ||
const vendorOption = options.vendorRoutes ? "" : "--except-vendor"; | ||
const routeListCommand = `php artisan route:list ${vendorOption} --json > ${tmpDir}/route.json`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a refactoring
Hi @7nohe, I made an attempt to resolve the issue I raised. Let me know if you have any issues or concerns about this change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks.
Issues
Changes
This PR changes the way to specify a model name in
php artisan model:show
command. This change is inspired from this comment below:model:show
command laravel/framework#43156 (comment)Meaning, conventionally
model:show
command was used like this:And moving forward,
model:show
command will be used like this:Output
Result of
debug.sh
Sample result of output in modular monolith structure: