feat(prefetch): add prefetch query hook generation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Closed
seriouslag
force-pushed
the
feature/add-prefetch-query-generation
branch
2 times, most recently
from
51fc0cf
to
e6c8645
Compare
7nohe
reviewed
Apr 27, 2024
src/createSource.mts
Outdated
| @@ -167,5 +192,9 @@ export const createSource = async ({ | |||
| name: "suspense.ts", | |||
| content: suspenseResult, | |||
| }, | |||
| { | |||
| name: "prefetch.ts", | |||
There was a problem hiding this comment.
Would it be possible to use OpenApiRqFiles from constants.mts for this part as well?
There was a problem hiding this comment.
Good catch. Updated.
seriouslag
force-pushed
the
feature/add-prefetch-query-generation
branch
from
e6c8645
to
6de9d38
Compare
7nohe
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds prefetch query generation.
I haven't tested this in an actual app to know if it is prefetching the data
Any help here would be great.
The example is working, but I haven't used prefetch before.
closes: #91
The JSDocs are added to the function but do not make the most sense.
This is because they list return types when prefetch functions do not return anything.