AdLib Gold changes: #2003
Merged
AdLib Gold changes: #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly implemented MIDI Out/In. Changed the ID from 0x50/0x70 to 0x51/0x71 to identify as AdLib Gold 1000. Added CD Audio volume and filter.
lemondrops
suggested changes
Jan 21, 2022
src/sound/snd_adlibgold.c
Outdated
| @@ -62,6 +62,7 @@ typedef struct adgold_t | |||
| int samp_vol_l, samp_vol_r; | |||
| int aux_vol_l, aux_vol_r; | |||
| int vol_l, vol_r; | |||
| int aux_vol_l, aux_vol_r; | |||
There was a problem hiding this comment.
Duplicate line, should be removed
| @@ -935,6 +965,7 @@ void *adgold_init(const device_t *info) | |||
| timer_add(&adgold->adgold_mma_timer_count, adgold_timer_poll, adgold, 1); | |||
|
|
|||
| sound_add_handler(adgold_get_buffer, adgold); | |||
| sound_set_cd_audio_filter(adgold_filter_cd_audio, adgold); | |||
There was a problem hiding this comment.
Duplicate line, should be removed
lemondrops
suggested changes
Jan 21, 2022
src/sound/snd_adlibgold.c
Outdated
Comment on lines
895
to
904
| static void | ||
| adgold_filter_cd_audio(int channel, double *buffer, void *p) | ||
| { | ||
| adgold_t *adgold = (adgold_t *)p; | ||
| double c; | ||
| double volume = channel ? adgold->aux_vol_r : adgold->aux_vol_l; | ||
|
|
||
| c = ((*buffer) * volume) / 128.0; /*Workaround to the low volume*/ | ||
| *buffer = c; | ||
| } |
There was a problem hiding this comment.
Not needed -- Ompronce has already implemented this
Polish translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly implemented MIDI Out/In.
Changed the ID from 0x50/0x70 to 0x51/0x71 to identify as AdLib Gold 1000.
Added CD Audio volume and filter (Courtsey of Ompronce!)
Summary
See above.
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.