Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALi M1435 southbridge and three new machines #3024

Merged
merged 7 commits into from Jan 9, 2023

Conversation

luennix
Copy link
Contributor

@luennix luennix commented Jan 9, 2023

Summary

Fixed ALi M1429G northbridge and added M1435 southbridge code from OBattler
Added MSI MS-4134 (machines/ms4134/4alm001.bin)
Added TriGem 486GP (machines/tg486gp/tg486gp.bin)
Added TriGem 486G (machines/tg486g/tg486g.bin)
NOTE: 486G needs some fixes regarding cache and CMOS setup before release.

Checklist

References

All fixes and new codes for both the chipsets and the machines are from OBattler, which I'm PRing at the request of him.

@lemondrops
Copy link
Contributor

the entire out directory isn't needed and should be removed

also, ali1429.c and ali1435.c will have to be updated to the new code style (though I suppose @jriwanek will take care of that?)

@luennix
Copy link
Contributor Author

luennix commented Jan 9, 2023

the entire out directory isn't needed and should be removed

I assume you're talking about the files generated by Visual Studio? If yes, I should have cleared those. My bad.

also, ali1429.c and ali1435.c will have to be updated to the new code style (though I suppose @jriwanek will take care of that?)

The codes for those come from OBattler, perhaps they will be updated?

@lemondrops
Copy link
Contributor

lemondrops commented Jan 9, 2023

The codes for those come from OBattler, perhaps they will be updated?

I was referring to the indentation style, which seems to still be the old tabs-spaces mix.

@OBattler OBattler merged commit 517e0e2 into 86Box:master Jan 9, 2023
@jriwanek
Copy link
Member

Yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants