Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable blink in 8bpp modes on MGA; Re-instate main 8bpp hires renderer #3893

Merged
merged 1 commit into from Dec 16, 2023

Conversation

iamgreaser
Copy link
Contributor

Summary

This should fix the blinking in 8bpp modes on the Matrix Millennium.

What I've been using to test this:

In a non-CJK MS-DOS 6.2x, run debug, then:

a100
mov ax, 13
int 10
int 3

g=100
q

Now you're in mode 13h, run qbasic and then exit it. (esc, alt, f, x - all separate keys)

The background should be black. If it's reddish-brown, then you've ended up in the weird thing that is 8bpp blink mode, which is supported by some VGA clones but not all. The Matrox Millennium card sets the blink bit, so what this PR does is it tells the renderer to ignore the blink bit when bpp > 4 on a Matrox card.

Checklist

  • I have discussed this with core contributors already

References

None

I don't actually know if 8bpp blink is a thing on a Matrox Millennium, but the video BIOS seems to act like it's not.
@OBattler OBattler merged commit b57b879 into 86Box:master Dec 16, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants