Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes typo on mac icon fix #3975

Merged
merged 2 commits into from Dec 31, 2023
Merged

fixes typo on mac icon fix #3975

merged 2 commits into from Dec 31, 2023

Conversation

brunocastello
Copy link
Contributor

@brunocastello brunocastello commented Dec 31, 2023

Summary

This fixes a typo on a mac icon fix submitted by lemondrops.
The original code uses
#ifndef Q_OS_APPLE
instead of
#ifndef __APPLE__

After changing this line, the correct icon appears on MacOS Dock, for both app window and settings window.

Checklist

References

OBattler

@lemondrops
Copy link
Contributor

lemondrops commented Dec 31, 2023

Are you sure? They should evaluate to the same thing.
Nevermind, my bad, it should've actually been Q_OS_MACOS instead.

src/qt/qt_main.cpp Outdated Show resolved Hide resolved
Accepted changes

Co-authored-by: Alexander Babikov <lemondrops358@gmail.com>
@jriwanek jriwanek merged commit 2cc84cf into 86Box:master Dec 31, 2023
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants