Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the PCAP filter to allow multicast packets #4289

Merged
merged 1 commit into from Mar 21, 2024

Conversation

cold-brewed
Copy link
Contributor

Summary

This PR modifies the PCAP filter accordingly:

  • Multicast packets are now passed through
  • The broadcast keyword is used instead of ff:ff:ff:ff:ff:ff

The biggest effect is fixing NetBEUI / NetBIOS which was not working before: NetBEUI uses a multicast address (03:00:00:00:00:01) instead of a standard ethernet broadcast which was not passing the PCAP filter.

Anything that uses NetBEUI / NetBIOS should now work with PCAP, including LAN Manager. Any other L3 that uses multicast should also now work.

Screenshot of win98 with no TCP/IP installed, using only NetBEUI to communicate with another win98 host configured the same:

netbeui

Checklist

  • I have discussed this with core contributors already

References

N/A

@NJRoadfan
Copy link

This should also fix AppleTalk if someone is using NT Services For Macintosh or PCMacLAN in a VM.

@OBattler OBattler merged commit a02118c into 86Box:version/4.2 Mar 21, 2024
46 checks passed
@cold-brewed cold-brewed deleted the pcap-filter branch March 21, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants