Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrobox-export doesn't handle .desktop filenames with whitespace #693

Closed
abyszuk opened this issue Apr 7, 2023 · 0 comments
Closed

distrobox-export doesn't handle .desktop filenames with whitespace #693

abyszuk opened this issue Apr 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@abyszuk
Copy link

abyszuk commented Apr 7, 2023

Describe the bug
If the .desktop filename contains whitespace, distrobox-export command seems to get confused.
It will print a few error messages coming from grep and then it seems to just hang. At least I've given up waiting after 15 minutes.

To Reproduce
I have following files in one of the directories:

adrian@vivado2018:~/praca$ ls -h ~/.local/share/applications/
Add Design Tools or Devices 2021.2_1644315538793.desktop 
Uninstall 2021.2_1644315538779.desktop  
Vitis HLS 2021.2 Command Prompt_1644315538645.desktop 
Vivado 2021.2_1644315538630.desktop 
Xilinx Vitis 2021.2_1644315538618.desktop
Documentation Navigator_1644315538843.desktop 
Uninstall DocNav_1644315538855.desktop 
Vitis HLS 2021.2_1644315538752.desktop 
Xilinx Information Center_1644315538977.desktop 
vivado2018.1.desktop
Manage Xilinx Licenses 2021.2_1644315538770.desktop 
Uninstall Xilinx Information Center_1644315538922.desktop 
Vivado 2021.2 Tcl Shell_1644315538624.desktop 
Xilinx Software Command Line Tool 2021.2_1644315538097.desktop

Expected behavior
Filenames containing whitespace are handled correctly.

Logs

adrian@vivado2018:~/praca$ distrobox-export --app vivado          
grep: /home/adrian/.local/share/applications/Vivado: No such file or directory
grep: 2021.2: No such file or directory
grep: Tcl: No such file or directory
grep: Shell_1644315538624.desktop: No such file or directory
grep: /home/adrian/.local/share/applications/Vivado: No such file or directory
grep: 2021.2_1644315538630.desktop: No such file or directory
^C

Desktop (please complete the following information):
Ubuntu 22.04 with Docker installed from PPA.
Distrobox installed from git repo (cloned 07.04.2023)

Additional context
Possibly related to #694 as I've noticed both these issues at once.

@abyszuk abyszuk added the bug Something isn't working label Apr 7, 2023
Scafir pushed a commit to Scafir/distrobox that referenced this issue May 3, 2023
Before, the elements in the desktop-files variable were enumerated using
the "for desktop-file in ${desktop-files}" syntax, which splits
at every whitespace. This is replaced by a more cumbersome variant
splitting at newlines.

Fixes 89luca89#693
Scafir pushed a commit to Scafir/distrobox that referenced this issue May 3, 2023
Before, the elements in the desktop-files variable were enumerated using
the "for desktop-file in ${desktop-files}" syntax, which splits
at every whitespace. This is replaced by a more cumbersome variant
splitting at newlines.

Fixes 89luca89#693
Scafir pushed a commit to Scafir/distrobox that referenced this issue May 23, 2023
Before, the elements in the desktop-files variable were enumerated using
the "for desktop-file in ${desktop-files}" syntax, which splits
at every whitespace. This is replaced by a more cumbersome variant
splitting at newlines.

Fixes 89luca89#693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant