init: fix mount flags for files (e.g., /etc/localtime)
#1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the checking of file or directory. - Updated variable names to reflect the changes.
weiren2
changed the title
/etc/localtime)/etc/localtime)
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1029.
Mount points may have additional flags (e.g.,
nodev,nosuid) to check for. However, the functionget_locked_mount_flagsexits immediately and returns an empty flag if the mount point is a file (e.g.,/etc/localtime). If the original mount point is a file and it has any "locked" flags, then the file will fail to bind mount as read-only without those "locked" flags (in rootless mode).I don't think it is necessary to exclude files when checking the mount flags. This PR removed that checking and updated the variable names to reflect the change.