Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --hostname argument and DBX_CONTAINER_HOSTNAME env var #1214

Merged
merged 3 commits into from Feb 18, 2024

Conversation

sandorex
Copy link
Contributor

I thought it would require more changes but its already passed to podman so why not have it as an option when it requires so little work

@sandorex
Copy link
Contributor Author

This would also remove the need for --init-hooks 'echo "$(uname -n)" > /etc/hostname' hacks which while they do kinda work they dont set the env var HOSTNAME and require more hacks on top of it

@89luca89
Copy link
Owner

That's a good idea @sandorex thanks!

Can you also adjust the documentation in docs/usage and the entry in useful_tips?
Thanks!

@sandorex
Copy link
Contributor Author

Can you also adjust the documentation in docs/usage and the entry in useful_tips?

Sure ill look into it now

@sandorex
Copy link
Contributor Author

sandorex commented Feb 18, 2024

I have not updated the shell autocompletions cause frankly it looks like magic 😄

@89luca89
Copy link
Owner

Autocompletion works with the --help so that should already be sorted :)

@89luca89
Copy link
Owner

Thanks a lot @sandorex ! ❤️

@89luca89 89luca89 merged commit d26a926 into 89luca89:main Feb 18, 2024
8 checks passed
@sandorex sandorex deleted the hostname-env-var branch March 9, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants