enter: make log_timestamp date format universally compatible #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested as working on Chimera Linux with FreeBSD date(1) and Alpine Linux with busybox date(1) which both cannot report nanoseconds or timezone with ':' separator only supported on GNU coreutils which handles these extensions via a strftime() wrapper in gnulib.
|
Thanks a lot for this! It is always good to have broader compatibiltiy :) thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested as working on Chimera Linux with FreeBSD
date(1)and Alpine Linux with busyboxdate(1)which both cannot report nanoseconds or timezone with:separator only supported on GNU coreutils which handles these extensions via astrftime()wrapper in gnulib.Digging deeper in https://github.com/mirror/busybox/blob/master/coreutils/date.c technically busybox can support at least nanoseconds if the Alpine one was compiled with
CONFIG_ENABLE_FEATURE_DATE_NANO=y, but it's not and%Nis still not portable. Besides I can't think of a situation where reading log output would need sub-second accuracy so in my eyes this should be perfectly fine.https://docs.podman.io/en/stable/markdown/podman-logs.1.html#since-timestamp lists some of the other supported formats, I basically picked one of the ISO 8601 options listed on https://ijmacd.github.io/rfc3339-iso8601/ while accounting for timezone offset by always dealing in UTC timestamps.