distrobox-export: add login shell option #651
Conversation
Add the option (-l or --login) to distrobox export so that the exported command runs inside a login shell, giving it access to the variables sourced during login (e.g: /etc/profile). If sudo is also specified, then care has been taken so that it also runs in a login shell (via -i).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Hi @Scafir thanks for the PR! Just a couple of comments there, they refer to the use of "${variable}" instead of $variable I think after fixing those, and running CI, we can merge |
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
|
All green, we can merge :) |
| if [ "${is_login}" -ne 0 ] && [ "${is_sudo}" -ne 0 ]; then | ||
| start_shell="sudo -i" | ||
| elif [ "${is_login}" -ne 0 ]; then | ||
| start_shell="sh -l -c" |
There was a problem hiding this comment.
This does not work for commands taking arguments since -c takes a string, and not arbitrary parameters. Also shouldn't it use the user shell rather than sh
There was a problem hiding this comment.
Thanks @fredizzimo I've pushed a fix for it :)
There was a problem hiding this comment.
Unfortunately, the fix does not seem to work, as for some reason, sudo prevents my user to run as himself:
Sorry, user XXX is not allowed to execute 'YYY' as XXX on ZZZ
Maybe the sudo -u ${USER} -i could be replaced by ${SHELL} -l?
There was a problem hiding this comment.
Looking a bit further, there is another issue that I don't quite understand. If you run bash gcc, it will abort with cannot execute binary file, whereas bash -c "gcc" successfully runs. It seems to me that having a structure like this:
${SHELL} -l -c "exportedCommand $@"
is the most general solution.
There was a problem hiding this comment.
In order to work around the issues I had here #656 I made changes to always run the login shell, no matter what. In distrobox-enter
result_command="${result_command} ${container_name}"
if [ -n "${container_command}" ]; then
- result_command="${result_command} ${container_command}"
+ quoted_container_command="\\\"${container_command}\\\""
+ result_command="${result_command} sh -c \"\\\$(getent passwd ${USER} | cut -f 7 -d :) -lc ${quoted_con
tainer_command}\""
else
# if no command was specified, let's execute a command that will find
# and run the default shell for the userSo that's basically what's @Scafir is suggesting to do here, allthough the quoting needed special handling there. I'm not sure if it's needed here as well.
By always running the login shell I can guarantee that the rc file is always run and I can unset and set the environment variables I want. This variant has been working well for me, but I'm not sure if that's the best way to solve the issues, so I have not sent any PR .But anyway I think a similar approach could be taken here as well.
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Add the option (
-lor--login) todistrobox-exportso that the exported command runs inside a login shell, giving it access to the variables sourced during login (e.g: /etc/profile).If
--sudois also specified, then care has been taken so that it also runs in a login shell (via -i).Fixes #639