Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only prompt to delete home if --rm-home is passed #896

Merged
merged 1 commit into from Aug 7, 2023

Conversation

AdamIsrael
Copy link
Contributor

@AdamIsrael AdamIsrael commented Aug 6, 2023

Only prompt the user to delete their mounted home directory (if it differs from $HOME) if they pass the --rm-home flag.

$ distrobox-rm -f acme
acme
$ distrobox-rm -f --rm-home acme
Do you want to remove custom home of container acme (/var/home/stone/Clients/ACME)? [y/N]: y
acme
Successfully removed /var/home/stone/Clients/ACME

This is a suggested solution to the pending discussion in issue #894 and resolves the issue raised in #895.

Only prompt the user to delete their mounted home directory (if it
differs from $HOME) if they pass the `--rm-home` flag.
@89luca89
Copy link
Owner

89luca89 commented Aug 7, 2023

Thanks! This is indeed very important, thanks a lot for the contribution! 😄

@89luca89 89luca89 merged commit 7e3f526 into 89luca89:main Aug 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants