-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Dockerfile to build Pakkero #4
Conversation
Thanks for the pull @alfonmga ! Testing locally works well with both docker and podman Could we add the EDIT: also you can add both docker and podman instructions in README as it works fine :) |
Podman ( I didn't know about Podman so thanks a lot for mentioning it :) |
Super thanks a lot @alfonmga Can I suggest to use With this dockerfile: FROM golang:alpine
ENV CGO_ENABLED=0
ENV GO111MODULE=off
RUN apk add --update-cache upx git make binutils coreutils \
&& rm -rf /var/cache/apk/*
RUN upx --version
RUN go version
RUN go get -d -v github.com/89luca89/pakkero
WORKDIR $GOPATH/src/github.com/89luca89/pakkero
RUN make
RUN ./dist/pakkero -v
ENTRYPOINT ["./dist/pakkero"] It generates a working image that clocks at ~370mb vs 914mb of standard debian based one :) EDIT: yea Podman is great and comes standard in Fedora based distro :) so confirmed also working on podman fedora and ubuntu great 👍 |
I prefer to use Alpine Linux distribution too. But recently I never go for it because I remember an article that I read some time ago, so I always go for a non-Alpine image because of that :) Anyways, in this case everything works as expected, the built image size is smaller and build time is faster, as we would expect from an Alpine image. I committed the change. |
Great thnks @alfonmga merging 👍 About the image size, yes the problem it's mainly on python images |
A
Dockerfile
would propose a solution to issues like #2 and #3.