Multi sectors #363
Open
Multi sectors #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Artifact 8vim-debug available until: 2023-10-06T20:42:40Z |
… and avoid right line.
…sitions when layout has not 6 sectors
|
I can help you to merge your PR from master since a lot of code changes happened 😅 (I'm keeping your logic, but I may adapt the code a bit) if you want |
|
I would be happy to get some help |
Conflicts: 8vim/src/main/java/inc/flide/vim8/geometry/Circle.java 8vim/src/main/java/inc/flide/vim8/keyboardactionlisteners/MainKeypadActionListener.java 8vim/src/main/java/inc/flide/vim8/keyboardhelpers/InputMethodServiceHelper.java 8vim/src/main/java/inc/flide/vim8/keyboardhelpers/KeyboardDataYamlParser.java 8vim/src/main/java/inc/flide/vim8/structures/CharacterPosition.java 8vim/src/main/java/inc/flide/vim8/structures/Constants.java 8vim/src/main/java/inc/flide/vim8/structures/Direction.java 8vim/src/main/java/inc/flide/vim8/structures/FingerPosition.java 8vim/src/main/java/inc/flide/vim8/structures/KeyboardData.java 8vim/src/main/java/inc/flide/vim8/structures/LayoutFileName.java 8vim/src/main/java/inc/flide/vim8/structures/Quadrant.java 8vim/src/main/java/inc/flide/vim8/structures/yaml/Action.java 8vim/src/main/java/inc/flide/vim8/structures/yaml/ExtraLayer.java 8vim/src/main/java/inc/flide/vim8/structures/yaml/Layer.java 8vim/src/main/java/inc/flide/vim8/structures/yaml/Part.java 8vim/src/main/java/inc/flide/vim8/utils/GeometricUtilities.java 8vim/src/main/java/inc/flide/vim8/utils/MovementSequenceHelper.java 8vim/src/main/java/inc/flide/vim8/views/mainkeyboard/XpadView.java 8vim/src/main/kotlin/inc/flide/vim8/models/CharacterPosition.kt 8vim/src/main/res/values/strings.xml 8vim/src/test/java/inc/flide/vim8/arbitaries/KeyboardActionsEntryArbitrary.java 8vim/src/test/java/inc/flide/vim8/arbitaries/MovementSequenceArbitrary.java 8vim/src/test/java/inc/flide/vim8/keyboardhelpers/InputMethodServiceHelperTest.java 8vim/src/test/java/inc/flide/vim8/keyboardhelpers/KeyboardDataYamlParserTest.java 8vim/src/test/java/inc/flide/vim8/structures/QuadrantTest.java 8vim/src/test/java/inc/flide/vim8/utils/GeometricUtilitiesTest.java 8vim/src/test/java/inc/flide/vim8/utils/MovementSequenceHelperTest.java README.md
|
Managed to merge it. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #363 +/- ##
============================================
+ Coverage 26.68% 27.01% +0.32%
- Complexity 88 93 +5
============================================
Files 46 45 -1
Lines 1454 1540 +86
Branches 229 240 +11
============================================
+ Hits 388 416 +28
- Misses 1033 1078 +45
- Partials 33 46 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is not ready to be merged, but I'm preparing a pull request to get some feeback. The idea is to support an arbitrary number of sectors. I hope that with 6 sectors my finger has to travel less and I can be a bit more efficient.
This pull request enables some of the designs in #35 and fixes the indexing in #360