Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service aliases to allow easier autowiring #301

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Added service aliases to allow easier autowiring #301

merged 3 commits into from
Apr 13, 2020

Conversation

tjveldhuizen
Copy link
Contributor

Q A
Bug fix no
New feature yes
BC breaks no
Deprecations no
Tests pass yes
Fixed tickets --
License MIT

Since Symfony 4.2, it is possible to create service aliases by class name and attribute. Inspired by the feature to auto-wire specific monolog channels I have created this pull request to make it easier to auto-wire Guzzle-clients.

@gregurco gregurco self-requested a review April 9, 2020 07:00
Copy link
Member

@gregurco gregurco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Tested on real project 🙂

Copy link
Member

@florianpreusner florianpreusner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👍 Thanks!

@gregurco gregurco merged commit cbb4c8d into 8p:master Apr 13, 2020
@tjveldhuizen
Copy link
Contributor Author

Thanks for merging. Can you give an indication about when an 8.1.0 release will be done, so I can decide if I use my own fork temporarily, or wait for the release?

@gregurco
Copy link
Member

@tjveldhuizen released: https://github.com/8p/EightPointsGuzzleBundle/releases/tag/v8.1.0

Thanks you for contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants