Fixed guzzle version constraints and avoid old promises function API #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GrahamCampbell
commented
May 23, 2023
•
GrahamCampbell
commented
| Q | A |
|---|---|
| Bug fix | yes |
| New feature | no |
| BC breaks | no |
| Deprecations | no |
| Tests pass | yes |
| Fixed tickets | #325 and #327 |
| License | MIT |
GrahamCampbell
commented
May 23, 2023
| @@ -27,7 +27,9 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=7.1", | |||
| "guzzlehttp/guzzle": "~6.0|~7.0", | |||
| "guzzlehttp/guzzle": "^6.5.8|^7.4.5", | |||
| "guzzlehttp/promises": "^1.5.3|^2.0", | |||
There was a problem hiding this comment.
This is added because you are implicitly using this dependency, and similarly for psr7.
| @@ -27,7 +27,9 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=7.1", | |||
| "guzzlehttp/guzzle": "~6.0|~7.0", | |||
| "guzzlehttp/guzzle": "^6.5.8|^7.4.5", | |||
There was a problem hiding this comment.
This is adjusted to avoid versions with known security vulnerabilities.
|
Test failures are unrelated. I have sent in a separate PR to fix that other broken test: #329. |
|
@GrahamCampbell could you please rebase your branch to apply the fix? |
GrahamCampbell
force-pushed
the
guzzle-fixes
branch
from
078b34b
to
0e1c972
Compare
|
CI passing now. |
|
@GrahamCampbell thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.