Feat connector server #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 48.62% 47.21% -1.41%
==========================================
Files 124 131 +7
Lines 10275 10604 +329
==========================================
+ Hits 4996 5007 +11
- Misses 5279 5597 +318 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+53
to
+94
| match event { | ||
| TransportIncomingEvent::State(state) => match state { | ||
| TransportStateEvent::Connected => { | ||
| self.outputs.push_back(self.build_event( | ||
| now_ms, | ||
| MediaEndpointEvent::Connected { | ||
| after_ms: (now_ms - self.started_ms.expect("Should has started")) as u32, | ||
| remote: None, //TODO | ||
| }, | ||
| )); | ||
| } | ||
| TransportStateEvent::Reconnecting => { | ||
| self.outputs.push_back(self.build_event( | ||
| now_ms, | ||
| MediaEndpointEvent::Reconnecting { | ||
| reason: "TODO".to_string(), //TODO | ||
| }, | ||
| )); | ||
| } | ||
| TransportStateEvent::Reconnected => { | ||
| self.outputs.push_back(self.build_event( | ||
| now_ms, | ||
| MediaEndpointEvent::Reconnected { | ||
| remote: None, //TODO | ||
| }, | ||
| )); | ||
| } | ||
| TransportStateEvent::Disconnected => { | ||
| self.outputs.push_back(self.build_event( | ||
| now_ms, | ||
| MediaEndpointEvent::Disconnected { | ||
| error: None, | ||
| duration_ms: now_ms - self.started_ms.expect("Should has started"), | ||
| received_bytes: 0, //TODO | ||
| rtt: F32::new(0.0), //TODO | ||
| sent_bytes: 0, //TODO | ||
| }, | ||
| )); | ||
| } | ||
| }, | ||
| _ => {} | ||
| } |
Check warning
Code scanning / clippy
you seem to be trying to use match for destructuring a single pattern. Consider using if let Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement connector server, which is used to intergrate with other system like:
Main idea is atm0s-media-server itseft don't do anything with hooks, logging. Instead of it will fire events to message queue like Kafka or NATS for easy extending media-server based on user business logic