Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename token terms #174

Merged
merged 4 commits into from
Jan 22, 2024
Merged

chore: rename token terms #174

merged 4 commits into from
Jan 22, 2024

Conversation

luongngocminh
Copy link
Contributor

No description provided.

@luongngocminh luongngocminh mentioned this pull request Jan 18, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (089b939) 49.28% compared to head (9a8cc54) 49.28%.

Files Patch % Lines
...ers/media-server/src/server/token_generate/http.rs 0.00% 5 Missing ⚠️
...ackages/cluster/src/implement/secure/jwt_static.rs 0.00% 2 Missing ⚠️
servers/media-server/src/server/token_generate.rs 0.00% 2 Missing ⚠️
servers/media-server/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files         152      152           
  Lines       13290    13290           
=======================================
  Hits         6550     6550           
  Misses       6740     6740

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

giangndm
giangndm requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@giangndm giangndm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update README.md according with the changes

@giangndm giangndm marked this pull request as ready for review January 19, 2024 08:03
giangndm
giangndm reviewed Jan 22, 2024
View reviewed changes
README.md Outdated

```
cargo build --release --package atm0s-media-server
```
- Or using Helm chart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only pushed related changes.

@giangndm
Copy link
Contributor

@luongngocminh Please fix conflict

@giangndm
Copy link
Contributor

@luongngocminh Thanks

@giangndm giangndm merged commit 7cf84e4 into 8xFF:master Jan 22, 2024
8 of 9 checks passed
@luongngocminh luongngocminh deleted the chore/rename-token-terms branch January 22, 2024 15:57
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giangndm giangndm giangndm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luongngocminh @giangndm