-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build warnings and clippy warnings #328
Conversation
- Added `rust-toolchain.toml` file with `channel` set to `"1.79.0"` - Added `rustfmt` and `clippy` components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for very carefully merge request, I have some comments and questions, let discuss more in details.
@giangndm Thank you for your response. I have addressed all your questions. Please let me know if you have more questions or feedbacks. |
@giangndm I have updated the code as per your feedbacks. Please let me know if I need to do more changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge it now. Thank you for great contribution.
Pull Request
Fix Cargo Build Warning and Clippy Warnings
Checklist