Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing before a release #2

Closed
907th opened this issue Feb 15, 2017 · 6 comments
Closed

Testing before a release #2

907th opened this issue Feb 15, 2017 · 6 comments

Comments

@907th
Copy link
Owner

907th commented Feb 15, 2017

@estepan I merged your PR and added some fixes. Do you have an ability to test the latest version of this gem on a real project/server? I just want to be sure that all is correct before releasing to rubygems.

@estepnv
Copy link
Contributor

estepnv commented Feb 17, 2017

@907th I'm already using master branch on one of my projects staging server. Everything is smooth. However, I'd suggest adding a notice to the README about explicitly setting up bundle_bin. Because in launch block when you are using rbenv it cannot find bundle in PATH. I had trouble with that.

@907th
Copy link
Owner Author

907th commented Feb 17, 2017

@estepan How did you resolved it? I think that rbenv users should require 'mina/rbenv' and invoke :'rbenv:load', it should make bundle command available without having to override :bundle_bin option manually.

@estepnv
Copy link
Contributor

estepnv commented Feb 17, 2017

That's the first approach.
But it forces you to invoke rbenv:load on each step of deployment.
I installed bundler via gem install so it appears in ~/.rbenv/shims. Then I assigned :bundle_bin to ~/.rbenv/shims/bundle

@907th
Copy link
Owner Author

907th commented Feb 17, 2017

@estepan Typically you should invoke :'rbenv:load' in an :environment task which is executed only once before every other task (at the start of the deploy, not on each step).

@907th
Copy link
Owner Author

907th commented Feb 17, 2017

@estepan I also added a fallback to clockworkd (without bundle exec prefix) when no :bundle_bin set in 4a29d42

@907th
Copy link
Owner Author

907th commented Feb 17, 2017

@estepan 🎉 I've released v1.0.0. Thank you for your help!

@907th 907th closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants