feat: minor changes from PR feedback

92green · Feb 21, 2024 · 0c92271 · 0c92271
1 parent ee11587
commit 0c92271
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 17 deletions.
diff --git a/packages/92green-aws-rxjs/CHANGELOG.md b/packages/92green-aws-rxjs/CHANGELOG.md
@@ -0,0 +1,7 @@
+# 0.12.0
+## Breaking Changes
+* queryAll no longer uses DynamoDBClient but instead uses DocumentClient preventing the need to marshall and unmarshall data
+* batchWriteRetry no longer accepts feedbackPipe to mutate data before import (this is probably better implemented in place where required)
+
+## Fixes
+* batchWriteRetry uses last to prevent it from emitting multiple times if there are unprocessed items
diff --git a/packages/92green-aws-rxjs/package.json b/packages/92green-aws-rxjs/package.json
@@ -24,6 +24,10 @@
     "test": "yarn build && yarn jest --maxWorkers=1"
   },
   "devDependencies": {
+    "@aws-sdk/client-dynamodb": "~3.515.0",
+    "@aws-sdk/lib-dynamodb": "~3.515.0",
+    "@aws-sdk/client-eventbridge": "~3.515.0",
+    "@aws-sdk/util-dynamodb": "~3.515.0",
     "@types/jest": "^27.4.1",
     "aws-sdk-client-mock": "^3.0.1",
     "jest": "^27.5.1",
@@ -34,7 +38,7 @@
   "peerDependencies": {
     "rxjs": "^7.1.0"
   },
-  "dependencies": {
+  "peer-dependencies": {
     "@aws-sdk/client-dynamodb": "^3.515.0",
     "@aws-sdk/lib-dynamodb": "^3.515.0",
     "@aws-sdk/client-eventbridge": "^3.515.0",

diff --git a/packages/92green-aws-rxjs/src/dynamodb/queryAll.ts b/packages/92green-aws-rxjs/src/dynamodb/queryAll.ts
@@ -33,7 +33,7 @@ export const queryAll = (docClient: DynamoDBDocumentClient, params: DocClientQue
             }
             return EMPTY;
         }),
-        concatMap(response => response.Items ? response.Items : []),
+        concatMap(response => response.Items ?? []),
     );
 };
 
@@ -53,7 +53,7 @@ export const queryAllDynamoDBClient = (dynamoClient: DynamoDBClient, params: Dyn
             }
             return EMPTY;
         }),
-        concatMap(response => response.Items ? response.Items : [])
+        concatMap(response => response.Items ?? [])
     );
 };
 

diff --git a/packages/92green-aws-rxjs/yarn.lock b/packages/92green-aws-rxjs/yarn.lock
@@ -64,10 +64,10 @@
     "@aws-sdk/util-utf8-browser" "^3.0.0"
     tslib "^1.11.1"
 
-"@aws-sdk/client-dynamodb@^3.515.0":
-  version "3.518.0"
-  resolved "https://registry.yarnpkg.com/@aws-sdk/client-dynamodb/-/client-dynamodb-3.518.0.tgz#c3ca2a7177ddfd14c07ac0bf37751e2dbe81be58"
-  integrity sha512-0ltO7vdMJ3wmZj4DLJ5aHgvnjmzGYl7qNZ+gabihlt9QFqhBU+di4u0tKfcJTRirQ5lEoy11D9Dg8hAHUQhm/g==
+"@aws-sdk/client-dynamodb@~3.515.0":
+  version "3.515.0"
+  resolved "https://registry.yarnpkg.com/@aws-sdk/client-dynamodb/-/client-dynamodb-3.515.0.tgz#20d72dba0447b233b43ce75fac3309ace5360673"
+  integrity sha512-0vReYeAlo6zXy+V+Utlj71WcBaL7Qro8yEmb/Hmgej5i2nTMWNwKrLW5/3MhtwHCWrxG0GP3xyw2sOaLdSfdjw==
   dependencies:
     "@aws-crypto/sha256-browser" "3.0.0"
     "@aws-crypto/sha256-js" "3.0.0"
@@ -113,7 +113,7 @@
     tslib "^2.5.0"
     uuid "^9.0.1"
 
-"@aws-sdk/client-eventbridge@^3.515.0":
+"@aws-sdk/client-eventbridge@~3.515.0":
   version "3.515.0"
   resolved "https://registry.yarnpkg.com/@aws-sdk/client-eventbridge/-/client-eventbridge-3.515.0.tgz#2c3a76166ec6e5e3c76af285c896bac7b59fdecd"
   integrity sha512-Po6aGh4hKkIDNsSX2Ce/mEQE2k+WNDhPHMG1NUgOGeWZWSygvZtrcjKUIriT8rpdDPCsMGmQq1+KQxBQdbnsKg==
@@ -408,12 +408,12 @@
     mnemonist "0.38.3"
     tslib "^2.5.0"
 
-"@aws-sdk/lib-dynamodb@^3.515.0":
-  version "3.518.0"
-  resolved "https://registry.yarnpkg.com/@aws-sdk/lib-dynamodb/-/lib-dynamodb-3.518.0.tgz#48f97f0582d410c7076a81f7c55eccd36f8aeeb5"
-  integrity sha512-XT06MKJoBu86CwbMESMTpie86JdTC2EVynK+7bo9M4AXG72t2agrsqVpGKmwKbHN/+C/78MHMjPVS4REe8ZzcQ==
+"@aws-sdk/lib-dynamodb@~3.515.0":
+  version "3.515.0"
+  resolved "https://registry.yarnpkg.com/@aws-sdk/lib-dynamodb/-/lib-dynamodb-3.515.0.tgz#9d8cccca21c63159051158d79e0be80bf46af091"
+  integrity sha512-nvrRFQoNiT67ih5c/lKU6nIdjFtx4TXSQkBnh89udSQErqqUhuNNLX4mPWaLPxMUYP/oORl61WeyNyPaaQdQrA==
   dependencies:
-    "@aws-sdk/util-dynamodb" "3.518.0"
+    "@aws-sdk/util-dynamodb" "3.515.0"
     "@smithy/smithy-client" "^2.3.1"
     "@smithy/types" "^2.9.1"
     tslib "^2.5.0"
@@ -549,10 +549,10 @@
   dependencies:
     tslib "^2.5.0"
 
-"@aws-sdk/util-dynamodb@3.518.0", "@aws-sdk/util-dynamodb@^3.515.0":
-  version "3.518.0"
-  resolved "https://registry.yarnpkg.com/@aws-sdk/util-dynamodb/-/util-dynamodb-3.518.0.tgz#14b45d8f7a4c777e0e8daee4ea8c070a53f23d30"
-  integrity sha512-XW2l7vcGlHMXRT2b8yTeqtN9p/PZ2sA0RSNEKRb/kE/81pmE2EhgVpx3WJOYh3nedmWP8p4W6z00rhom12p5lg==
+"@aws-sdk/util-dynamodb@3.515.0", "@aws-sdk/util-dynamodb@~3.515.0":
+  version "3.515.0"
+  resolved "https://registry.yarnpkg.com/@aws-sdk/util-dynamodb/-/util-dynamodb-3.515.0.tgz#d59fead60ad2834fc75ea120e3e716b3064fb811"
+  integrity sha512-HCduLubTlkoxqggF7/Lx26ns+C+idXoXbI3F3y0+sIuBPUi3pDrIAjew8LkL7lmvM4D4frDuCdFOABPTOO6Eug==
   dependencies:
     tslib "^2.5.0"