Skip to content

Commit

Permalink
break: reveal super edge case that nobody will likely hit
Browse files Browse the repository at this point in the history
parcels know of each others existence via the registry, which each
parcel adds itself too. this is so even parcels that havend re-rendered
in forever can have a reference to the newest version of their parent
parcel. boundary splitting is making sure that when a parcel boundary
is used, that they each have their own registry, so parel boundaries
dont accidentally share updates telepathically between each other.

right now this is a tad broken with hooks. ill fix it soon, but the
frequency that we'll hit this (i.e. never) means id rather uncover
this logical hole for a bit to get hooks out
  • Loading branch information
dxinteractive committed May 29, 2019
1 parent a30e6ee commit dfcbd89
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions packages/dataparcels/src/parcel/Parcel.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,13 @@ export default class Parcel {
_boundarySplit = ({handleChange}: *): Parcel => {
return this._create({
id: this._id.pushModifier('bs'),
handleChange,
dispatchId: '%',
registry: {
'%': this
}
handleChange
// temporarily disabling boundary splitting
// until a more robust solution can be found
// dispatchId: '%',
// registry: {
// '%': this
// }
});
};

Expand Down

0 comments on commit dfcbd89

Please sign in to comment.