Refactor lastOriginId and add mergeMode #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frameMetas job is to hold data that should only exist until the next change occurs (the current parcel frame) lastOriginId requires that same data lifespan lastOriginId was a concept that only react-dataparcels was interested in, and probably shouldnt have been put in plain dataparcels
replacing the inner parcel from props is intended to be a complete reset, so the buffer should also be emptied
dxinteractive
force-pushed
the
feature/merge-mode
branch
from
c0a810c
to
a9b4bf7
Compare
when no rebasing and new data is received from props, buffer is wiped and buffers state is replaced with data from props when rebasing and new data is received from props, buffers state is replaced with data from props with buffer applied to it also fixed a wrong test that was relying on incorrect cachebehaviour in a change request
dxinteractive
force-pushed
the
feature/merge-mode
branch
from
a9b4bf7
to
5028f16
Compare
dxinteractive
changed the title
allanhortle
approved these changes
Jul 15, 2019
allanhortle
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataparcels
_lastOriginId, replace with more genericframeMetadispatch()when it shouldreact-dataparcels
useParcelBuffer(and thereforeuseParcelForm) to rebase changes whenframeMeta.mergeMode === "rebase"