Feature/rebasing #233
Merged
Feature/rebasing #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes can then describe meta for the resulting parcel update and re-render This will be used by react-dataparcels to set the merge mode when a change is about to take place, as the change is thee thing that knows which merge mode that is appropriate
this will allow changes from props to slide in underneath changes in useParcelBuffer hooks and ParcelBoundaries, so data can change without losing unsaved changes.
dxinteractive
force-pushed
the
feature/rebasing
branch
from
7ac9991
to
a464dd7
Compare
allanhortle
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataparcels
frameMetabased offChangeRequest.nextFrameMetareact-dataparcelsto set the merge mode when a change is about to take place, as the change is the thing that knows which merge mode that is appropriatereact-dataparcels
rebaseoption onuseParcelStateanduseParcelFormsubmit()to not get replaced once a promise returned byonSubmitresolves. Only affects cases whereonSubmitUseResultis not used. IfonSubmitUseResultthen replacing the value is the right behaviour.