Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/shrinky time #245

Merged
merged 23 commits into from
Jul 29, 2019
Merged

Conversation

dxinteractive
Copy link
Collaborator

@dxinteractive dxinteractive commented Jul 27, 2019

Addresses #241, part of #242

dataparcels

Size of default import was 13.1KB, now 10.7KB (19% decrease)

  • BREAKING CHANGES
    • Removed parentParcel.toObject()
    • Removed parentParcel.set(key, value) (parcel.set(value) still exists)
    • Removed parentParcel.update(key, updater) (parcel.update(updater) still exists)
    • Removed parentParcel.delete(key) (childParcel.delete() still exists)
    • Removed parentParcel.setIn() completely
    • Removed parentParcel.updateIn() completely
    • Removed parentParcel.deleteIn() completely
    • Removed parentParcel.insertAfter(key, value) (childParcel.insertAfter(value) still exists)
    • Removed parentParcel.insertBefore(key, value) (childParcel.insertBefore(value) still exists)
    • Removed elementParcel.move(otherKey) (parentParcel.move(keyA, keyB) still exists)
    • Removed elementParcel.swap(otherKey) (parentParcel.swap(keyA, keyB) still exists)
    • Removed parentParcel.swapNext(otherKey) (elementParcel.swapNext() still exists)
    • Removed parentParcel.swapPrev(otherKey) (elementParcel.swapPrev() still exists)
    • Removed shape.toObject()
    • Removed shape.move() completely
    • Removed swap() completely
    • Removed swapNext() completely
    • Removed swapPrev() completely
    • Removed changeRequest.toJS()
    • Removed action.toJS()
  • Refactor to move parcel methods and parcel id methods onto parcel class
  • Temporarily disabled runtime type checking

@dxinteractive dxinteractive merged commit c97f8f1 into release/cumbersome-crocodile Jul 29, 2019
@dxinteractive dxinteractive deleted the feature/shrinky-time branch August 7, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants