Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extra #19

Merged
merged 11 commits into from
Oct 9, 2017
Merged

Feature/extra #19

merged 11 commits into from
Oct 9, 2017

Conversation

dxinteractive
Copy link
Collaborator

Additions

  • Added unmutable-extra with pivot function (uniqueBy and averageBy would be good in future)
  • Added keyArray() to all collections, which works like keySeq but returns an array of keys.
  • Added filter() and filterNot() to unmutable-lite arrays
  • Added every(), filter(), filterNot() and some() to unmutable-lite objects.

Fixes

  • reduce() no longer unwraps returned data item.
  • set() and setIn() now have their values shallowly unwrapped before setting them, to try and prevent accidental nesting of unmutable objects. The same treatment should also go for all methods that accept new values as parameters like unshift() or insert().

@dancoates
Copy link

Looks good, just wondering if the nested readme files need to be committed? Just makes the diffs a bit bigger than necessary and they'd still show up on NPM even if they weren't

@dxinteractive dxinteractive merged commit f52a188 into master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants