-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpb-qt: qt5/eglfs image (no window manager) #33
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
require conf/distro/include/rpb.inc | ||
|
||
DISTRO_NAME = "Reference-Platform-Build-EGLFS" | ||
|
||
PACKAGECONFIG_append_pn-qtbase = " eglfs kms" | ||
|
||
DISTRO_FEATURES_remove = "wayland x11" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
SUMMARY = "Basic QT5 image" | ||
|
||
IMAGE_FEATURES += " package-management debug-tweaks ssh-server-openssh hwcodecs tools-debug" | ||
|
||
LICENSE = "MIT" | ||
|
||
inherit core-image distro_features_check extrausers | ||
|
||
# let's make sure we have a good image.. | ||
REQUIRED_DISTRO_FEATURES = "pam systemd opengl" | ||
|
||
# by default and without x11-base in IMAGE_FEATURES we default to multi-user.target | ||
SYSTEMD_DEFAULT_TARGET = "multi-user.target" | ||
|
||
CORE_IMAGE_BASE_INSTALL += " \ | ||
96boards-tools \ | ||
alsa-utils-aplay \ | ||
networkmanager \ | ||
networkmanager-nmtui \ | ||
coreutils \ | ||
gps-utils \ | ||
gpsd \ | ||
gptfdisk \ | ||
gstreamer1.0-plugins-bad-meta \ | ||
gstreamer1.0-plugins-base-meta \ | ||
gstreamer1.0-plugins-good-meta \ | ||
${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial_gstreamer1.0-libav", "gstreamer1.0-libav", "", d)} \ | ||
hostapd \ | ||
iptables \ | ||
kernel-modules \ | ||
sshfs-fuse \ | ||
cinematicexperience \ | ||
qt5everywheredemo \ | ||
qtbase-examples \ | ||
${@bb.utils.contains("MACHINE_FEATURES", "optee", "optee-test optee-client", "", d)} \ | ||
" | ||
|
||
EXTRA_USERS_PARAMS = "\ | ||
useradd -p '' linaro; \ | ||
" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove gstreamer and gps packages compared to the other images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably want to keep the x11 packages as well, but check for X11 in DISTRO_FEATURES. I believe this image should be used for DISTRO=rpb and DISTRO=rpb-wayland, and in case of rpb it should be using Qt5 over x11 backend, so the x11 packages would be needed.
in fact we might eventually end up with a single desktop image, who knows..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of them (gps I think) seemed to require x11. will add them back and retest.
same thing for the gstreamer plugins (gstreamer1.0-plugins-bad-meta)
ok checking DISTRO_FEATURES in the image install.