Fix crashes in keychain Get & Remove #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines were causing
serviceRef
to be released twice. It looks like some copy/paste shenanigans from the blocks just above where I've made these changes, e.g. keychain.go:59. I think it's pretty safe to assume from the context that these lines were meant to releaseaccountRef
notserviceRef
.These were causing a crash on macOS 10.12 beta that looked like: