Simplify implicit external check

99designs · Dec 5, 2022 · 3c39158 · 3c39158
1 parent 8d4973a
commit 3c39158
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/plugin/federation/entity.go b/plugin/federation/entity.go
@@ -37,10 +37,7 @@ type Requires struct {
 
 func (e *Entity) allFieldsAreExternal(federationVersion int) bool {
 	for _, field := range e.Def.Fields {
-		if field.Directives.ForName("external") == nil {
-			if e.isFieldImplicitlyExternal(field, federationVersion) {
-				continue
-			}
+		if !e.isFieldImplicitlyExternal(field, federationVersion) && field.Directives.ForName("external") == nil {
 			return false
 		}
 	}