fix optional input fields (fixes #25)

99designs · Nov 20, 2016 · 4838c6f · 4838c6f
1 parent a15deed
commit 4838c6f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/graphql_test.go b/graphql_test.go
@@ -764,7 +764,7 @@ func TestMutation(t *testing.T) {
 			Variables: map[string]interface{}{
 				"ep": "JEDI",
 				"review": map[string]interface{}{
-					"stars":      float64(5),
+					"stars":      5,
 					"commentary": "This is a great movie!",
 				},
 			},
@@ -778,6 +778,32 @@ func TestMutation(t *testing.T) {
 			`,
 		},
 
+		{
+			Schema: starwarsSchema,
+			Query: `
+				mutation CreateReviewForEpisode($ep: Episode!, $review: ReviewInput!) {
+					createReview(episode: $ep, review: $review) {
+						stars
+						commentary
+					}
+				}
+			`,
+			Variables: map[string]interface{}{
+				"ep": "EMPIRE",
+				"review": map[string]interface{}{
+					"stars": float64(4),
+				},
+			},
+			ExpectedResult: `
+				{
+					"createReview": {
+						"stars": 4,
+						"commentary": null
+					}
+				}
+			`,
+		},
+
 		{
 			Schema: starwarsSchema,
 			Query: `

diff --git a/internal/exec/exec.go b/internal/exec/exec.go
@@ -690,6 +690,9 @@ func coerceMap(r *request, io *common.InputMap, m map[string]interface{}) (map[s
 	for _, iv := range io.Fields {
 		value, ok := m[iv.Name]
 		if !ok {
+			if _, nonNull := unwrapNonNull(iv.Type); !nonNull {
+				continue
+			}
 			if iv.Default == nil {
 				return nil, errors.Errorf("missing %q", iv.Name)
 			}