testing: proper error on invalid ExpectedResult

99designs · Nov 7, 2016 · 5ce3ca6 · 5ce3ca6
1 parent 8f7d2b1
commit 5ce3ca6
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/testing.go b/testing.go
@@ -40,17 +40,15 @@ func RunTest(t *testing.T, test *Test) {
 		t.Fatal(err)
 	}
 
-	want := formatJSON([]byte(test.ExpectedResult))
+	var v interface{}
+	if err := json.Unmarshal([]byte(test.ExpectedResult), &v); err != nil {
+		t.Fatalf("invalid JSON for ExpectedResult: %s", err)
+	}
+	want, _ := json.Marshal(v)
+
 	if !bytes.Equal(got, want) {
 		t.Logf("want: %s", want)
 		t.Logf("got:  %s", got)
 		t.Fail()
 	}
 }
-
-func formatJSON(data []byte) []byte {
-	var v interface{}
-	json.Unmarshal(data, &v)
-	b, _ := json.Marshal(v)
-	return b
-}