Skip to content

Commit

Permalink
github: Fix CI pipelines (#2266)
Browse files Browse the repository at this point in the history
* github: Test more go versions

* github: Fix ci tests

* github: Increase verbosity, sleep

* github: Drop bash

* github: Test go 1.18 and newer node verisons

* github: Pull out node 16 for now

* github: Only lint 1.16 for now
  • Loading branch information
tmc committed Jul 3, 2022
1 parent c287a7b commit b8497f5
Show file tree
Hide file tree
Showing 6 changed files with 65 additions and 28 deletions.
11 changes: 10 additions & 1 deletion .github/workflows/check-federation
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,16 @@ cd _examples/federation

./start.sh &

sleep 10
sleep 5
curl -s --connect-timeout 5 \
--max-time 10 \
--retry 5 \
--retry-delay 5 \
--retry-max-time 40 \
--retry-connrefused \
localhost:4003 > /dev/null

sleep 1

echo "### running jest integration spec"
./node_modules/.bin/jest --color
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/check-integration
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,17 @@ set -euo pipefail

cd integration

date
go run ./server/server.go &

sleep 2
sleep 5
curl -s --connect-timeout 5 \
--max-time 10 \
--retry 5 \
--retry-delay 5 \
--retry-max-time 40 \
--retry-connrefused \
localhost:8080 > /dev/null

echo "### running jest integration spec"
./node_modules/.bin/jest --color
Expand Down
35 changes: 26 additions & 9 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
@@ -1,35 +1,52 @@
name: Integration
on: [push, pull_request]

env:
GO_VERSION: 1.16

jobs:
integration:
strategy:
matrix:
go: [1.16, 1.18]
node: [14]
runs-on: ubuntu-latest
timeout-minutes: 3
container: golang:${{ env.GO_VERSION }}-alpine
steps:
- uses: actions/checkout@v3
- run: apk add --no-cache --no-progress nodejs npm git bash
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: go mod download
- run: cd integration ; npm install
- run: .github/workflows/check-integration

federation:
strategy:
matrix:
go: [1.16, 1.18]
node: [14]
runs-on: ubuntu-latest
container: golang:${{ env.GO_VERSION }}-alpine
steps:
- uses: actions/checkout@v3
- run: apk add --no-cache --no-progress nodejs npm git bash
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: go mod download
- run: cd _examples/federation ; npm install
- run: .github/workflows/check-federation

init:
strategy:
matrix:
go: [1.16, 1.18]
runs-on: ubuntu-latest
container: golang:${{ env.GO_VERSION }}-alpine
steps:
- uses: actions/checkout@v3
- run: apk add --no-cache --no-progress alpine-sdk bash
- uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go }}
- run: .github/workflows/check-init
21 changes: 13 additions & 8 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,41 +1,46 @@
name: Lint
on: [push, pull_request]

env:
GO_VERSION: 1.16

jobs:
lint:
strategy:
matrix:
go: [1.16]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ matrix.go }}
- run: go mod download
- run: .github/workflows/check-fmt
- run: .github/workflows/check-generate

coverage:
strategy:
matrix:
go: [1.16]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ matrix.go }}
- run: go mod download
- run: .github/workflows/check-coverage
env:
COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

golangci-lint:
strategy:
matrix:
go: [1.16]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install Go
uses: actions/setup-go@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ matrix.go }}
- name: golangci-lint
uses: golangci/golangci-lint-action@v3.1.0
with:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/security.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
name: Security
on: [push, pull_request]

env:
GO_VERSION: 1.16

jobs:
nancy:
strategy:
matrix:
go: [1.16, 1.18]

This comment has been minimized.

Copy link
@giautm

giautm Jul 3, 2022

Contributor

I'm not sure why we skip one version (1.17) here.

This comment has been minimized.

Copy link
@giautm

giautm Jul 3, 2022

Contributor

I found the comment: #2266 (comment)

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ matrix.go }}
- run: go mod download && go list -json -deps all > go.list
- uses: sonatype-nexus-community/nancy-github-action@main
8 changes: 3 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
name: Test
on: [push, pull_request]


env:
GO_VERSION: 1.16

jobs:
test:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
go: [1.16, 1.18]
runs-on: ${{ matrix.os }}
continue-on-error: true
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION }}
go-version: ${{ matrix.go }}
- run: go mod download && go test -race ./...
- run: cd _examples && go mod download && go test -race ./...

0 comments on commit b8497f5

Please sign in to comment.