Do not strip ptr for args with defaults

This fails if a client still sends a null value. If an arg is nullable but has a default, then null is still a valid value to send through.
99designs · Oct 2, 2018 · f5c0340 · f5c0340
1 parent 0c39927
commit f5c0340
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/codegen/directive_build.go b/codegen/directive_build.go
@@ -32,7 +32,6 @@ func (cfg *Config) buildDirectives(types NamedTypes) ([]*Directive, error) {
 				if err != nil {
 					return nil, errors.Errorf("default value for directive argument %s(%s) is not valid: %s", dir.Name, arg.Name, err.Error())
 				}
-				newArg.StripPtr()
 			}
 			args = append(args, newArg)
 		}

diff --git a/codegen/object_build.go b/codegen/object_build.go
@@ -162,7 +162,6 @@ func (cfg *Config) buildObject(types NamedTypes, typ *ast.Definition, imports *I
 				if err != nil {
 					return nil, errors.Errorf("default value for %s.%s is not valid: %s", typ.Name, field.Name, err.Error())
 				}
-				newArg.StripPtr()
 			}
 			args = append(args, newArg)
 		}