Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity with graphql implementations #1037

Closed
nitin302 opened this issue Feb 17, 2020 · 3 comments
Closed

Feature parity with graphql implementations #1037

nitin302 opened this issue Feb 17, 2020 · 3 comments

Comments

@nitin302
Copy link

Hello I'm looking for comparisons in feature parity with the latest graphql specification.

Is gqlgen at par with the latest stable one? http://spec.graphql.org/ and what is the plan for feature releases when a new specification is out.

I'm mainly trying to find out if there is a parity difference between the JS implementations (as they seem to be the most used in production) in comparison to gqlgen.

  • Are all features covered? Is there anything missing? in comparison with the JS implementation or the latest available spec
  • If there is a new spec release, how fast would it be able to implement those changes.
@vektah
Copy link
Collaborator

vektah commented Feb 17, 2020

We use https://github.com/vektah/gqlparser

spec target: June 2018 (Schema definition language, block strings as descriptions, error paths & extension)

Which is still the latest stable spec https://spec.graphql.org/June2018/. Take a look at the diff to see whats going to land in the next release.

Almost everything is supported, notable exception is the ability to implement some directives.

The tests from the reference implementation (graphql-js) are used to test the go parser, but they haven't been imported in a while and some work is needed to get them running again. Will likely happen before 1.0.

@nitin302
Copy link
Author

nitin302 commented Feb 17, 2020

Thank you, when is the target for 1.0? @vektah

Also, Is it possible to add directives to the comparison. Do you know if others in the list support all directives?

@vektah
Copy link
Collaborator

vektah commented Feb 17, 2020

Yeah that list needs an update, it takes a bit of effort to go through the libraries to review them. I'll create a new issue and close this - #1042

@vektah vektah closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants