EPIC: Directive support

[vektah]

Here to track the status of directives

⚠️ these features are subject to change - if you are using any of these features make sure you have tests on your directives that actually run queries against a graph. ⚠️

Execution directives

location	implemented	obj is
QUERY	✔️ #744	*ast.OperationDefinition
MUTATION	✔️ #744	*ast.OperationDefinition
SUBSCRIPTION	✔️ #744	*ast.OperationDefinition
FIELD	✔️ #756	parent type
FRAGMENT_DEFINITION	⛔
FRAGMENT_SPREAD	⛔
INLINE_FRAGMENT	⛔

Schema directives

location	implemented	obj is
SCHEMA	⛔
SCALAR	⛔
OBJECT	✔️ #1117	parent type
FIELD_DEFINITION	✔️	parent type
ARGUMENT_DEFINITION	✔️ #460	argument bag
INTERFACE	⛔
UNION	⛔
ENUM	⛔
ENUM_VALUE	⛔
INPUT_OBJECT	⛔
INPUT_FIELD_DEFINITION	✔️	parent input

Schema field directives on subscriptions

obj is always nil for any root (Query, Mutation, Subscription)
next() returns a channel of the field type

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dbadura]

Hello,
what happen with directive on ARGUMENT_DEFINITION?

[dtrckd]

Hi,
I've commented on a potential problem with OBJECT directive, here.

[logrusorgru]

Hi, there.

There are a few questions about directives. Commonly most about INPUT_FIELD_DEFINITION. It is marked with a check mark and its input object is a parent object.

1. The gqlgen generator doesn't allow directives with INPUT_FIELD_DEFINITION on input fields. But allows them on the input fields with FIELD_DEFINITION.
2. Object received in a directive handler is map[string]interface{}, not a Go object. Is it by design? Why not Go object?
3. The following directive produce invalid server that panics just before the directive called

directive @allowValueType (field: String!, allow: [ValueTypeAllow!]) on
	INPUT_FIELD_DEFINITION |
	FIELD_DEFINITION # <- have to add

enum ValueType {
	ONE
	TWO
}

input ValueTypeAllow {
	valueType: ValueType!
	allow:     Boolean!
}

input InputValue {
	name:      String!
	valueType: ValueType! @allowValueType (field: "valueType", allow: [
		ValueTypeAllow{valueType: ONE, allow: true},
		ValueTypeAllow{valueType: TWO, allow: true}
	])
}

However, it's okay with the 3rd point if the directive receives strings for example

directive @allowValueType (field: String!, allow: [String!]) on
	INPUT_FIELD_DEFINITION |
	FIELD_DEFINITION # <- have to add

input InputValue {
	name:      String!
	valueType: ValueType! @allowValueType (field: "valueType", allow: [
		"ONE:true",
		"TWO:true"
	])
}

There is repository that represents all of them https://github.com/logrusorgru/gqlif . It can be cloned and executed with go run main.go. Then, trying to execute

mutation a($name: String!, $value: InputValue!) {
    set (name: $name, value: $value) {name valueType}
}

with

{"name": "pew-pew", "value": {"name": "one", "valueType": "ONE"}}

You will got the panic.

Best regards.

[dangolbeeker]

Have you found a patch yet?