Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix same field name in two different fragments #1284

Merged
merged 7 commits into from
Aug 18, 2020

Conversation

JatinDev543
Copy link

@JatinDev543 JatinDev543 commented Aug 14, 2020

Describe your PR and link to any relevant issues.
This PR solves issue (#1280 issue) by adding check for object defination name with name of the field.

I have:

  • Added tests covering the bug / feature (see testing)

@JatinDev543 JatinDev543 changed the title added check for object defination name fix same field name in two different fragments Aug 14, 2020
@coveralls
Copy link

coveralls commented Aug 14, 2020

Coverage Status

Coverage remained the same at 66.267% when pulling 8a7f3e6 on dgraph-io:jatin/sameFieldSameTypeGettingIgnored into 08eee0f on 99designs:master.

@abhimanyusinghgaur
Copy link
Contributor

abhimanyusinghgaur commented Aug 17, 2020

Hi @lwc,

Please help us in getting this PR reviewed.
Also, would love to know any estimates on releasing the next version.

Thanks

@lwc lwc merged commit 108975c into 99designs:master Aug 18, 2020
@lwc
Copy link
Member

lwc commented Aug 18, 2020

Looks good thanks 👍

@abhimanyusinghgaur abhimanyusinghgaur deleted the jatin/sameFieldSameTypeGettingIgnored branch August 18, 2020 09:19
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
…ypeGettingIgnored

fix same field name in two different fragments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants