Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve import handling #147

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Improve import handling #147

merged 3 commits into from
Jun 26, 2018

Conversation

vektah
Copy link
Collaborator

@vektah vektah commented Jun 23, 2018

Fixes for a few bugs in import handling:

  • imports will now use the package name defined in the package, instead of generating one
  • dont do name decollisioning until all imports have been resolved and sorted
  • use a case insensitive compare for determining if a package refers to itself

Fixes #114 and maybe #143

@eric-am
Copy link

eric-am commented Jun 25, 2018

😍

@vektah vektah merged commit cb87a2c into master Jun 26, 2018
@vektah vektah deleted the import-overhaul branch June 26, 2018 09:08
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
@vektah
Merge pull request 99designs#147 from vektah/import-overhaul
e7657b9 
Improve import handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deterministic import names
2 participants
@vektah @eric-am