Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out autobind in the sample config file #1872

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Comment out autobind in the sample config file #1872

merged 1 commit into from
Jan 31, 2022

Conversation

frederikhors
Copy link
Collaborator

@frederikhors frederikhors commented Jan 31, 2022

The reason is that many people using it for the first time copy exactly that configuration example and then open the issues to say it doesn't work.

Describe your PR and link to any relevant issues.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@StevenACoffman I tried all the steps and everything works.

@softshipper also confirmed here: #1860 (comment).

Fixes #1860.

The reason is that many people using it for the first time copy exactly that configuration example and then open the issues to say it doesn't work.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 75.062% when pulling a450225 on frederikhors:patch-1 into a30b68d on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Thanks!

@StevenACoffman StevenACoffman merged commit f9fcfa1 into 99designs:master Jan 31, 2022
@frederikhors frederikhors deleted the patch-1 branch January 31, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generating core failed: unable to load example/graph/model in v0.16
3 participants