Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten some generated code #2120

Merged
merged 2 commits into from Apr 25, 2022
Merged

Conversation

vikstrous
Copy link
Contributor

I was reading some templates and saw that this code can be shorter, so I shortened it. Less code is better than more, right?

I have:

  • [n/a] Added tests covering the bug / feature (see testing)
  • [n/a] Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Apr 24, 2022

Coverage Status

Coverage increased (+0.05%) to 74.497% when pulling b71ce35 on vikstrous:simplify-code into 4da17e1 on 99designs:master.

@StevenACoffman
Copy link
Collaborator

Thanks for working on improving things! It looks like .github/workflows/check-generate is failing, but that might just mean a test needs to be updated or something. I'm away from a computer right now, so it's hard to tell from my phone.

@StevenACoffman StevenACoffman merged commit 77260e8 into 99designs:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants