fix: chat example frontend race condition #2219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the race condition bug revealed by #2209.
I have also noticed
this.cache.batch
error that was caused by an incorrectly importedInMemoryCache
fromapollo-cache-inmemory
, because it has been exported by the@apollo/client
since v3, and the chat example is using v3.2.3.It's far from perfect, but at least
this.cache.batch
error and the race condition are gone now.I have: