Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support named interface to Field.CallArgs #2289

Merged
merged 1 commit into from Jul 13, 2022
Merged

Conversation

vvakame
Copy link
Collaborator

@vvakame vvakame commented Jul 13, 2022

types.IsInterface returns true when passed value's underlying type is interface.
its too much in this situation.
so, if argument type is something like type ID interface { isID() }, types.IsInterface returns true. it will generate unexpected code.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Jul 13, 2022

Coverage Status

Coverage decreased (-0.08%) to 74.997% when pulling dc6c304 on fix-named-interface into 3049369 on master.

@StevenACoffman StevenACoffman merged commit 6310e6a into master Jul 13, 2022
@StevenACoffman StevenACoffman deleted the fix-named-interface branch July 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants