feat: make Playground HTML content compatible with UTF-8 charset #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
The current Playground page content and Playground server doesn't compatible with UTF-8 charset. This may result in string corruption and page content unusable if the developers would try to use UTF-8 strings/contents in their schemas or Playground title.
The compatible has been done by:
Content-Typeheader withtext/html; charset=UTF-8<meta charset="utf-8">in<head>section and before<title>elementIn most of the usage scenarios, the Playground would be configured to be deployed behind a gateway or reverse proxy, so I added the UTF-8 support for both
Content-Typeheader and template to prevent the mis-configuration of gateway or reverse proxy where it may cause the HTML parser got lost to find out the encoding of the content on the browser side.references
<meta>: The metadata element - HTML: HyperText Markup Language | MDNRelated to: #2354
I have: