Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST transport: missing return and unnecessary logs #2584

Merged
merged 2 commits into from
Mar 15, 2023
Merged

POST transport: missing return and unnecessary logs #2584

merged 2 commits into from
Mar 15, 2023

Conversation

Desuuuu
Copy link
Contributor

@Desuuuu Desuuuu commented Mar 15, 2023

The HTTP POST transport was missing a return in the first error case.

I also removed the two log.Printf calls which seem to have been left there unintentionally.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage: 78.723% (-0.003%) from 78.725% when pulling 91a2d80 on Desuuuu:post-transport into 622039c on 99designs:master.

@StevenACoffman StevenACoffman merged commit 05500c9 into 99designs:master Mar 15, 2023
@StevenACoffman
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants