Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow binding a GraphQL Any field to a struct method returning *any #2644

Merged
merged 4 commits into from
May 24, 2023
Merged

allow binding a GraphQL Any field to a struct method returning *any #2644

merged 4 commits into from
May 24, 2023

Conversation

Tooni
Copy link
Contributor

@Tooni Tooni commented May 24, 2023

related issue:
#2643

i noticed there was code doing a similar fix for the pointer-to-slice case, so i added the pointer-to-interface{} case to that code. This fixes my use-case

pointer-to-slice issue and fix:
#1333
#1363

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@Tooni Tooni changed the title allow binding a GraphQL Any field to a struct method returning …*any` allow binding a GraphQL Any field to a struct method returnin*any May 24, 2023
@Tooni Tooni changed the title allow binding a GraphQL Any field to a struct method returnin*any allow binding a GraphQL Any field to a struct method returning *any May 24, 2023
@StevenACoffman
Copy link
Collaborator

Hey, thanks for the improvement, but I noticed there were some test failures.

Can you try:

go generate ./...; cd _examples; go generate ./...; cd ..; go test ./...; cd _examples; go test ./...

@Tooni
Copy link
Contributor Author

Tooni commented May 24, 2023

Hey, thanks for the improvement, but I noticed there were some test failures.

Can you try:

go generate ./...; cd _examples; go generate ./...; cd ..; go test ./...; cd _examples; go test ./...

thank you for the quick response! i didnt realise there were followschema tests as well as singlefile tests. i've added them and your command is passing for me locally now.

@coveralls
Copy link

coveralls commented May 24, 2023

Coverage Status

Coverage: 78.898% (+0.06%) from 78.834% when pulling 14768b7 on Tooni:fix-pointer-to-any-binding into c313bf3 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 22deb8b into 99designs:master May 24, 2023
18 checks passed
@StevenACoffman
Copy link
Collaborator

Great! Thanks very much and I'm looking forward to your next PR!

@Tooni Tooni deleted the fix-pointer-to-any-binding branch May 29, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants